[feature] reimplement Snapshot manifest cache#1185
Closed
kevinjqliu wants to merge 3 commits intoapache:mainfrom
Closed
[feature] reimplement Snapshot manifest cache#1185kevinjqliu wants to merge 3 commits intoapache:mainfrom
kevinjqliu wants to merge 3 commits intoapache:mainfrom
Conversation
kevinjqliu
changed the title
This was referenced Sep 19, 2024
sungwy
approved these changes
Sep 20, 2024
Collaborator
There was a problem hiding this comment.
Thanks for fixing this issue @kevinjqliu ! That was an admirable debugging effort. I've confirmed that this fixes the issue on my Mac as well 🎉
| schema_id: Optional[int] = Field(alias="schema-id", default=None) | ||
|
|
||
| # Private attribute for caching the manifests | ||
| _manifest_cache: Optional[List[ManifestFile]] = PrivateAttr(default=None) |
Collaborator
There was a problem hiding this comment.
This looks promising @kevinjqliu
I know this is a regression from the intended optimization at the module level as suggested here: #787 (comment) but I don't think we have a better alternative 🙂
Contributor
Author
|
Closing in favor of #1187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595, Reverts #787, Closes #1162
Implement manifest list cache as Snapshot instance-specific cache, not global cache